Re: [Libvir] [PATCH] Remote 0/8: Plan

[Daniel Veillard <veillard redhat com>]

On Wed, May 02, 2007 at 07:08:28PM +0100, Richard W.M. Jones wrote:
> Richard W.M. Jones wrote:
> >1 Additional error handling
> >---------------------------
> >
> >M include/libvirt/virterror.h
> >M src/virterror.c
> 
> Attached is the patch to add the additional types of errors to 
> virterror.  VIR_FROM_REMOTE indicates that the error originated in the 
> remote driver.  There are two further subclasses for general RPC-related 
> errors and GnuTLS-related errors.
> 
> Note that if a regular error (eg. VIR_FROM_XEN) is generated on the 
> server side it is passed through the connection to the client 
> transparently (there is no "wrapping" of errors or anything like that).

  Looks fine to me, the only comment I have is that if you have an extra
string you expect it to be the full message error instead of just an
extra information, but that's okay.

  Please apply I don't see anything controversial there :-)

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/