[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] [PATCH] conftest: fix transposed size and count arguments to fwrite.
- From: Daniel Veillard <veillard redhat com>
- To: Jim Meyering <jim meyering net>
- Cc: Libvirt <libvir-list redhat com>
- Subject: Re: [Libvir] [PATCH] conftest: fix transposed size and count arguments to fwrite.
- Date: Mon, 12 Nov 2007 17:05:55 -0500
On Mon, Nov 12, 2007 at 10:57:50PM +0100, Jim Meyering wrote:
> I noticed conftest fail and tracked it down to this:
>
> conftest: fix transposed size and count arguments to fwrite.
> * tests/conftest.c: Include <string.h> and <errno.h>.
> Also include strerror in diagnostic.
[...]
> - if (fwrite(buffer, len, 1, stdout) != len) {
> - fprintf(stderr, "Write failed\n");
> + if (fwrite(buffer, 1, len, stdout) != len) {
> + fprintf(stderr, "Write failed: %s\n", strerror (errno));
Good catch, +1 !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard redhat com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]