[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] PATCH: Fix const-ness for attach/detach device APIs
- From: Daniel Veillard <veillard redhat com>
- To: "Richard W.M. Jones" <rjones redhat com>
- Cc: libvir-list redhat com
- Subject: Re: [Libvir] PATCH: Fix const-ness for attach/detach device APIs
- Date: Mon, 15 Oct 2007 08:17:50 -0400
On Mon, Oct 15, 2007 at 12:49:34PM +0100, Richard W.M. Jones wrote:
> Daniel P. Berrange wrote:
> >virDomainAttachDevice and virDomainDetachDevice both take a char * for the
> >XML description, but this is mistakenly not declared to be const. This
> >patch fixes the public header files & all the internal drivers. NB, yes
> >this
> >is in the public API, no it won't break any apps since these are input
> >params only.
>
> +1
yes this is safe +1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard redhat com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]