[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] PATCH: Implement CDROM media change for QEMU/KVM driver
- From: Jim Paris <jim jtan com>
- To: "Richard W.M. Jones" <rjones redhat com>
- Cc: libvir-list redhat com
- Subject: Re: [Libvir] PATCH: Implement CDROM media change for QEMU/KVM driver
- Date: Mon, 15 Oct 2007 11:19:36 -0400
Richard W.M. Jones wrote:
> Richard W.M. Jones wrote:
> >+ strcat(cmd, newdisk->src);
>
> Also, is quoting/escaping required? In a naive libvirt-based app, it's
> plausible that the string is provided by the user and could contain \n
> to send arbitrary commands to the qemu console.
Agreed. We can use something like qemudEscapeShellArg for that.
This (untested) patch adds qemudEscapeArg for non-shell arguments.
-jim
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]