[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] detect overflow in string-to-int conversion
- From: Daniel Veillard <veillard redhat com>
- To: Jim Meyering <jim meyering net>
- Cc: Libvirt <libvir-list redhat com>
- Subject: Re: [Libvir] detect overflow in string-to-int conversion
- Date: Wed, 24 Oct 2007 10:22:37 -0400
On Wed, Oct 24, 2007 at 03:52:22PM +0200, Jim Meyering wrote:
> Hi,
>
> Not a big deal, but it's better not to accept a bogus
> "4294967297" and silently map it to "1".
>
> Don't accept an arbitrarily-long string of digits.
> * src/xml.c (parseNumber): Detect overflow.
Right, thanks !
I just fully reparenthesized the test before applying. I also reindented
the full module since there were some misleading indentations. It's commited,
thanks a lot !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard redhat com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]