[Libvir] [PATCH] finish NUMA code reorg, plug cpuset at creat time support

Saori Fukuta fukuta.saori at jp.fujitsu.com
Thu Oct 25 08:25:25 UTC 2007


On Wed, 24 Oct 2007 05:12:42 -0400 Daniel Veillard wrote:
> On Wed, Oct 24, 2007 at 04:38:50PM +0900, Saori Fukuta wrote:
> > I confirmed how I can get the cpus values at fedora8(xen-3.1.0-10.fc8),
> > and I expected to be emitted "(cpus '0,1')", when I specified 
> > "cpuset='0,1'". But xend shows nothing about cpus.
> 
>   Right don't assume it's there on output of the xend S-Expr for that
> domain, look at xm info --long it doesn't show it. 

Yep, it's my fault. Thank you for pointing that.

> To extract the cpuset
> you need to call the existing functionalities we have for the vcpu 
> affinities (and this may be a bit costly).
> 
> > Then, I could not get the cpus values by sexpr_node(root, "domain/cpus").
> > 
> > I guess this is a bug of Xen, and this has not been fixed with latest
> > upstream Xen. So I will work about this for Xen before discussing about
> > how xend exports.
> 
>   It was never in xen and I think teh new way being based on Xen-API you
> won't get a fix for upstream for our case here. I would not expect a fix
> to xend to get the solution but work it out in libvirt, but you can try ...

I reconsidered about it and I agreed with you, because we won't get 
the cpus values when pined several PCPU to each VCPU, like the 
following case:
   domA  VCPU:0  PCPU:0-1
         VCPU:1  PCPU:0-1
         VCPU:2  PCPU:2
         VCPU:3  PCPU:3
And, we certainly can get the vcpu affinities above by other way 
(i.e. call "xenDaemonDomainGetVcpus" and analyze the result), but
it will be costly at this time, though I would like to make them.
So could you commit the patch first to support the cpus value 
at starting/defining the guest domain for RHEL5.2 ? 

Please let me know if you have any comments and suggestions.

  thanks !

Saori
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cpuset_add2.patch
Type: application/octet-stream
Size: 2341 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20071025/378a2af5/attachment-0001.obj>


More information about the libvir-list mailing list