Re: [Libvir] [PATCH] Fix failure of HVM domain definition on Xen 3.0.3 or earlier(BZ328841)

[Daniel Veillard <veillard redhat com>]

On Tue, Oct 23, 2007 at 02:14:29PM +0900, Masayuki Sunou wrote:
> Hi
> 
> VirDomainDefineXML() fails, when HVM domain using CD-ROM is created
> on Xen 3.0.3 or earlier.
>  -->BZ328841(https://bugzilla.redhat.com/show_bug.cgi?id=328841)
> 
> One of attached patches (define.patch) fixes it.

  Could you please explain the patch, it changes the XML parsing and
seems to change the S-Expr generation. How ? Providing examples or 
explanations of how the patch works will help.

> But, when domain is started by virsh start using the configuration
> file created by fixing this,
> the problem that the CD-ROM device is missed occurs.
> 
> So, another patch (start.patch) fixes this problem.
> 
> Signed-off-by: Masayuki Sunou <fj1826dm aa jp fujitsu com>

  Again this seems to change parsing of S-Expr input to accept
an empty value. Could you explain what this patch does, i.e. 
what kind of input is being targetted and what is changed by
the patch.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/