Re: [Libvir] [RFC] Linux-VServer support

[Daniel Veillard <veillard redhat com>]

On Wed, Oct 31, 2007 at 02:24:58PM +0100, Daniel Hokka Zakrisson wrote:
> Daniel P. Berrange wrote:
> >On Tue, Oct 30, 2007 at 04:28:59PM +0100, Daniel Hokka Zakrisson wrote:
> >>This is an initial stab at adding Linux-VServer support to libvirt. 
> >>There are still a couple of things missing, like scheduler support in 
> >>the XML parsing, and proper network support.
> >
> >Great to see interest in adding more drivers ! I've not had time to look
> >at your patch in great detail yet, but I'll give some more detailed
> >feedback in the next day or so. My first comment though - why the 
> ><xid>123</xid> field in the XML - the unique integer ID for a domain
> >should really be in the 'id' attribute  <domain id='123'>. There are a
> >couple of other small XML format consistency issues like that to check
> >up on.
> 
> Yeah, the only reason I did it with a separate element was that I really 
> don't know XPath, so I hadn't figured out how to get the id in that case.

  prefix the name with @ to say your accessing an attribute children
instead of an element children e.g.:
   '/domain/@id'
if XPath is the only real problem that can be solved easilly,
grab me on IRC !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/