[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[Libvir] also check for useless test-before-xmlFree
- From: Jim Meyering <jim meyering net>
- To: Libvirt <libvir-list redhat com>
- Subject: [Libvir] also check for useless test-before-xmlFree
- Date: Tue, 29 Apr 2008 16:07:06 +0200
Some time ago, Daniel Veillard assured me that xmlFree(NULL) is
valid in regular use, and with upstream code since January it's
ok even in a debug mode that's not normally available because
it's ifdef'd out:
http://mail.gnome.org/archives/svn-commits-list/2008-January/msg02233.html
Since the potential NULL-deref in debug mode is now gone,
we can now use this to prevent any new useless tests:
also check for useless test-before-xmlFree
* Makefile.cfg (useless_free_options): Add --name=xmlFree.
diff --git a/Makefile.cfg b/Makefile.cfg
index e0d5528..cbf97c2 100644
--- a/Makefile.cfg
+++ b/Makefile.cfg
@@ -53,5 +53,6 @@ local-checks-to-skip = \
useless_free_options = \
--name=sexpr_free \
+ --name=xmlFree \
--name=xmlXPathFreeContext \
--name=xmlXPathFreeObject
--
1.5.5.1.68.gbdcd8
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]