Re: [libvirt] [Charles_Duffy@messageone.com: [PATCH] autoport overrides actual VNC port number in dump-xml]

[Daniel Veillard <veillard redhat com>]

On Thu, Jul 31, 2008 at 02:17:25PM +0100, Daniel P. Berrange wrote:
> On Thu, Jul 31, 2008 at 02:24:25PM +0200, Chris Lalancette wrote:
> > Daniel Veillard wrote:
> > >> So the explicit port is output in XML if autoport is not set, or
> > >> if the domain is running.
> > > 
> > >   Okay +1, push the patch :-)
> > 
> > Yes, I agree, I just tested out the patch and it seems to fix the issue for me.
> >  I'm going to commit the patch now.
> 
> You committed the wrong patch it appears - the original one instead of my
> revised version :-(

  Seems fixed now, I'm seeing 

    case VIR_DOMAIN_GRAPHICS_TYPE_VNC:
        if (def->data.vnc.port &&
            (!def->data.vnc.autoport || vm->id != -1))
            virBufferVSprintf(buf, " port='%d'",
                              def->data.vnc.port);
        else if (def->data.vnc.autoport)
            virBufferAddLit(buf, " port='-1'");

        virBufferVSprintf(buf, " autoport='%s'",
                          def->data.vnc.autoport ? "yes" : "no");
in CVS head,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/