[libvirt] [Charles_Duffy at messageone.com: [PATCH] autoport overrides actual VNC port number in dump-xml]

Chris Lalancette clalance at redhat.com
Fri Aug 1 06:37:04 UTC 2008


Daniel Veillard wrote:
>   Seems fixed now, I'm seeing 
> 
>     case VIR_DOMAIN_GRAPHICS_TYPE_VNC:
>         if (def->data.vnc.port &&
>             (!def->data.vnc.autoport || vm->id != -1))
>             virBufferVSprintf(buf, " port='%d'",
>                               def->data.vnc.port);
>         else if (def->data.vnc.autoport)
>             virBufferAddLit(buf, " port='-1'");
> 
>         virBufferVSprintf(buf, " autoport='%s'",
>                           def->data.vnc.autoport ? "yes" : "no");

Yeah, Dan B committed the fix to the fix, since I didn't get around to it
yesterday.  Thanks Dan B!

Chris Lalancette




More information about the libvir-list mailing list