[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh edit, virsh net-edit, virsh pool-edit



On Fri, Aug 01, 2008 at 10:02:50AM +0200, Jim Meyering wrote:
> "Richard W.M. Jones" <rjones redhat com> wrote:
> > +static int
> > +cmdEdit (vshControl *ctl, vshCmd *cmd)
> > +{
> ...
> > +static int
> > +cmdNetworkEdit (vshControl *ctl, vshCmd *cmd)
> > +{
> ...
> > +static int
> > +cmdPoolEdit (vshControl *ctl, vshCmd *cmd)
> > +{
> 
> Have you considered factoring these three?
> At 70-80 lines each, with so much common code, it's begging for it.

I certainly did!

Normally of course I'd do it with closures, but ...

I'll go with the 'sed' approach unless anyone stronly objects to that.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]