[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] sexpr.c: reviving an old const-correct change



On Fri, Aug 01, 2008 at 04:12:05PM +0200, Jim Meyering wrote:
> I wrote this months ago and forgot about it:
> 
> diff --git a/src/xend_internal.c b/src/xend_internal.c
> index 880a279..1e6e875 100644
> --- a/src/xend_internal.c
> +++ b/src/xend_internal.c
> @@ -2171,7 +2171,7 @@ error:
>   */
>  static virDomainDefPtr
>  xenDaemonParseSxpr(virConnectPtr conn,
> -                   struct sexpr *root,
> +                   const struct sexpr *root,
>                     int xendConfigVersion,
>                     const char *cpus)
>  {
> 
> 
> 
> When you pull the thread (i.e., eliminate all resulting
> warnings that arise from the above change), you end up with
> the following additional const-adding changes:
> (I'll squash the two into a single change set before committing)
> 

  Looks fine too, +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]