[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix MinGW compilation(200808)



On Tue, Aug 05, 2008 at 04:24:08PM +0900, Atsushi SAKAI wrote:
> Hi,
> 
> Currently, compilation for MinGW is broken.
> Here is the patch.
> But configure script option for MinGW is changed from previous posting.
> https://www.redhat.com/archives/libvir-list/2008-June/msg00145.html
> 
> Currently, it should do
> # ./configure --without-xen --without-qemu --without-sasl --without-lxc --without-openvz --without-libvirtd --without-test

  yes I made compilation with lxc and openvz default now, so changing this
is normal.

> currently following 3 make works,
> make
> make install
> make check
> I do not know why syntax-check is not exist on Makefile on MinGW.

  I would expect most development to still be done on Linux/Unix, so
that's not a big deal IMHO

>  src/domain_conf.c    |    2 ++
>  src/network_conf.c   |    2 ++

  basically the changes remove compilations from the XML parsing code.
On one end I understand why it's not needed (currently) but I wonder why
this need to be defined out. Seems to me the code should compile on WIN32
and that's an important point if we ever want to get some native hypervisor
support there.
  So what miscompiled there ? Can we fix it ? in the interim having the code
compiled out as the patch does is fine, but I would like to understand.

>  src/virsh.c          |    8 ++++++++

  edit on windows will be nasty, vi or $EDITOR is unixy

>  tests/testutilsxen.c |    2 ++

  okay

>  4 files changed, 14 insertions(+)

  I think the patch is fine for now, but I would like to understand why
the conf files compile need to be supressed.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]