[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]: Rework xenLinuxDomainDeviceID to support more devices



On Tue, Aug 05, 2008 at 03:45:40PM +0200, Chris Lalancette wrote:
> Jim Meyering wrote:
> > To retain the diagnostic Dan mentioned, you should be able to
> > insert something like this just before the final "else":
> > 
> >     else if (disk_re_match("/dev/sd[a-z]([0-9])+$", mod_path, &part)) {
> > 
> >> +    else
> >> +        statsErrorFunc (conn, VIR_ERR_INVALID_ARG, __FUNCTION__,
> >> +                        "unsupported path, use xvdN, hdN, or sdN", domid);
> 
> OK, another go, with all of Jim's concerns addressed.  I did something like this
> last point (thanks for the idea Jim), except that I didn't use regex's but basic
> STRPREFIX() to get better error messages.  Dan, is this better?

ACK, this gets my vote now.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]