[libvirt] [PATCH]: Fix sexpr generation again
Daniel P. Berrange
berrange at redhat.com
Wed Aug 6 10:24:22 UTC 2008
On Wed, Aug 06, 2008 at 12:20:50PM +0200, Chris Lalancette wrote:
> DanB pointed out that my sexpr xend_internal patch from yesterday broke one of
> the regression tests. The problem is that the xenDaemonFormatSxpr{Disk,Net}
> functions are shared between domain creation time and attaching disk time.
> Unfortunately, though, Xend expects something different during these two times.
> During domain creation time, it wants the "(device" in front of the sexpr,
> while during attach time it does not. To remedy this situation, I added a flag
> to these two functions to differentiate between these two modes. With this
> patch in place, all of the regression tests pass.
>
> Signed-off-by: Chris Lalancette <clalance at redhat.com>
ACK, thanks for fixing this up.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list