Re: [libvirt] [PATCH] fix MinGW compilation(200808)

[Atsushi SAKAI <sakaia jp fujitsu com>]

Hi, Jim

I have a question about inet_pton().
I try to compile libvirt on MinGW after some modification.
The error message says follows.
C:/msys/1.0/home/sakaia/work/libvirt/src/network_conf.c:290: undefined reference to `inet_pton'
C:/msys/1.0/home/sakaia/work/libvirt/src/network_conf.c:296: undefined reference to `inet_pton'

I think it should edit gnulib/lib/Makefile.am.
Is this my guess correct.

Thanks
Atsushi SAKAI


Jim Meyering <jim meyering net> wrote:

> Atsushi SAKAI <sakaia jp fujitsu com> wrote:
> ...
> > network_conf.c:290: warning: implicit declaration of function `inet_aton'
> > network_conf.c:290: warning: nested extern declaration of `inet_aton'
> 
> We can/should use inet_pton instead.  Then, not only do we use what seems
> to be the preferred interface, but there is a gnulib module by the same
> name that can come into play if it too is missing.
> 
> > network_conf.c:598: error: `S_IRUSR' undeclared (first use in this function)
> 
> The remaining problems should be easy to resolve:
> Add this line to network_conf.c:
> 
> #include <sys/stat.h>
> 
> > network_conf.c:598: error: (Each undeclared identifier is reported only once
> > network_conf.c:598: error: for each function it appears in.)
> > network_conf.c:598: error: `S_IWUSR' undeclared (first use in this function)