Re: [libvirt] update from gnulib

[Jim Meyering <jim meyering net>]

Daniel Veillard <veillard redhat com> wrote:
...
>> However, I suspect some of them have not yet been exercised
>> on RHEL4/5 systems, so test builds there may be interesting.
>
> on RHEL5 configure/make passes, make tests fails one of the 18 tests:
...
> for RHEL4 i need the followig patch for it to compile (the function changed
> but the signature of the dummy didn't get fixed)

Looks fine.  ACK.

> Index: src/bridge.c
> ===================================================================
> RCS file: /data/cvs/libvir/src/bridge.c,v
> retrieving revision 1.16
> diff -u -p -r1.16 bridge.c
> --- src/bridge.c	11 Jul 2008 19:34:11 -0000	1.16
> +++ src/bridge.c	7 Aug 2008 09:54:05 -0000
> @@ -156,9 +156,7 @@ brAddBridge(brControl *ctl,
>  }
>  #else
>  int brAddBridge (brControl *ctl ATTRIBUTE_UNUSED,
> -                 const char *nameOrFmt ATTRIBUTE_UNUSED,
> -                 char *name ATTRIBUTE_UNUSED,
> -                 int maxlen ATTRIBUTE_UNUSED)
> +                 char **name ATTRIBUTE_UNUSED)
...
>   basically gnulib update seems to not be a problem !

Good to hear.
Thanks for the quick checks!