[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [libvirt] PATCH: Fix const-ness for virRun/virExec
- From: Jim Meyering <jim meyering net>
- To: "Daniel P. Berrange" <berrange redhat com>
- Cc: libvir-list redhat com
- Subject: Re: [libvirt] PATCH: Fix const-ness for virRun/virExec
- Date: Fri, 08 Aug 2008 13:47:29 +0200
"Daniel P. Berrange" <berrange redhat com> wrote:
> The exec() family of UNIX functions have broken const-ness in the argv[]
> parameter. For inexplicable reasons, I followed this brokeness when
> originally doing the virRun/virExec functions. So every caller is either
> using wrong const-ness, or having to cast when calling them. This patch
> fixes the virRun/virExec API const-ness, so we only need apply a cast
> at the time we finally call exec()
+1 to massive cast removal + const-correctness fixes ;-)
Nice.
ACK
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]