Re: [libvirt] [PATCH] Ensure parted doesn't prompt if labeling disk

[Jim Meyering <jim meyering net>]

Cole Robinson <crobinso redhat com> wrote:
> Trying to 'build' a disk pool uses 'parted mklabel' which can
> prompt for confirmation. Patch adds the '--script' option to
> remove the chance of this happening.
>
> diff --git a/src/storage_backend_disk.c b/src/storage_backend_disk.c
> index d6548eb..39b857c 100644
> --- a/src/storage_backend_disk.c
> +++ b/src/storage_backend_disk.c
> @@ -406,6 +406,7 @@ virStorageBackendDiskBuildPool(virConnectPtr conn,
>          PARTED,
>          pool->def->source.devices[0].path,
>          "mklabel",
> +        "--script",
>          virStorageBackendDiskPoolFormatToString(conn, pool->def->source.format),
>          NULL,
>      };

Good change.
ACK.