Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

[Jim Meyering <jim meyering net>]

Cole Robinson <crobinso redhat com> wrote:
> parted doesn't seem to want the label 'dos', instead
> wanting 'msdos'. Patch is basically s/dos/msdos/

Hi Cole,

This definitely needs to be fixed.

FYI, "dos" appears to be the preferred name for that partition table type
(google for "partition table" and either "dos" or "msdos"; also, partx
--type accepts "dos", not "msdos").  Too bad Parted added the "ms" prefix.
If it's not hard to implement, it would be nice to hide the implementation
detail that Parted happens to call it the "msdos" label type.

> diff --git a/docs/storage.html.in b/docs/storage.html.in
> index 40e8e80..8cab480 100644
> --- a/docs/storage.html.in
> +++ b/docs/storage.html.in
> @@ -258,7 +258,7 @@ libvirt.
>      </p>
>      <ul>
>        <li>
> -        <code>dos</code>
> +        <code>msdos</code>
...