[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'



On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote:
> Jim Meyering wrote:
> > Cole Robinson <crobinso redhat com> wrote:
> >> parted doesn't seem to want the label 'dos', instead
> >> wanting 'msdos'. Patch is basically s/dos/msdos/
> > 
> > Hi Cole,
> > 
> > This definitely needs to be fixed.
> > 
> > FYI, "dos" appears to be the preferred name for that partition table type
> > (google for "partition table" and either "dos" or "msdos"; also, partx
> > --type accepts "dos", not "msdos").  Too bad Parted added the "ms" prefix.
> > If it's not hard to implement, it would be nice to hide the implementation
> > detail that Parted happens to call it the "msdos" label type.
> > 
> 
> We could just keep the outward facing label the same, and internally
> map it to use msdos if calling 'parted mklabel' since it's the only
> command that seems to use that value. Whatever people think is best.

Yep, I'd prefer that we just special case it internally when calling
out to mklabel.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]