[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'



On Tue, Aug 12, 2008 at 11:12:07AM +0100, Daniel P. Berrange wrote:
> On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote:
> > Jim Meyering wrote:
> > > Cole Robinson <crobinso redhat com> wrote:
> > >> parted doesn't seem to want the label 'dos', instead
> > >> wanting 'msdos'. Patch is basically s/dos/msdos/
> > > 
> > > Hi Cole,
> > > 
> > > This definitely needs to be fixed.
> > > 
> > > FYI, "dos" appears to be the preferred name for that partition table type
> > > (google for "partition table" and either "dos" or "msdos"; also, partx
> > > --type accepts "dos", not "msdos").  Too bad Parted added the "ms" prefix.
> > > If it's not hard to implement, it would be nice to hide the implementation
> > > detail that Parted happens to call it the "msdos" label type.
> > > 
> > 
> > We could just keep the outward facing label the same, and internally
> > map it to use msdos if calling 'parted mklabel' since it's the only
> > command that seems to use that value. Whatever people think is best.
> 
> Yep, I'd prefer that we just special case it internally when calling
> out to mklabel.

  Fine by me, my only worry is that we are somehow breaking the storage XML
format as a result, but I don't think this is widely used at this point
(at least with MSDos) and best done earlier than later,

  Applied and commited,

    thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]