Re: [libvirt] [PATCH] Ensure parted doesn't prompt if labeling disk

[Daniel Veillard <veillard redhat com>]

On Mon, Aug 11, 2008 at 09:53:48AM -0400, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Sun, Aug 10, 2008 at 10:40:30PM -0400, Cole Robinson wrote:
> >> Trying to 'build' a disk pool uses 'parted mklabel' which can
> >> prompt for confirmation. Patch adds the '--script' option to
> >> remove the chance of this happening.
> > 
> > Can you double-check this works on RHEL-5 - IIRC, the --script arg is
> > a fairly recent addition to parted.
> > 
> 
> My 5.2 box has it. The --script option is also used elsewhere in the
> disk code, so I assume it's safe.

  makes sense and safe, 

    applied and commited, thanks again :-)

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/