Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

[Daniel Veillard <veillard redhat com>]

On Tue, Aug 12, 2008 at 11:58:12PM -0400, Cole Robinson wrote:
> Daniel Veillard wrote:
> >   Fine by me, my only worry is that we are somehow breaking the storage XML
> > format as a result, but I don't think this is widely used at this point
> > (at least with MSDos) and best done earlier than later,
> >
> >   Applied and commited,
> >
> >     thanks !
> >
> > Daniel
> >   
> Wait, I think there was a bit of miscommunication. I think Jim and Dan
> were recommending
> a different approach then the patch that was committed.
> 
> The attached patch keeps the public facing formats the same, we just
> special case the dos
> format to use "msdos" if calling out to parted (this would require the
> current patch to be
> reverted though).

  Okay, I think I'm the one who misunderstood, so reverted and applied the
new fix which only change at the parted call level.

  Sorry :-)

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/