[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 2/7: Re-arrange methods acros LXC source files



On Mon, Aug 11, 2008 at 07:16:20PM +0200, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange redhat com> wrote:
> > The lxc_driver.c file contains quite a large amount of code,
> > serving two reasonably well separated purposes. First there
> > is the direct implemntation of each of the libvirt driver
> > APIs. Second there is the code to spawn a container and a
> > controller for forwarding I/O to/from the PTYs. This patch
> > attempts to re-arrange the code across files to better reflect
> > the split in functionality. The general idea is thus:
> >
> >  - lxc_driver.c: implementation of the libvirt driver APIs
> >  - lxc_container.c: code for creating containers
> >  - lxc_controller.c: code for managing an active container
> >
> > So this entails the following re-arrangement:
> 
> Most changes were straight function copies.
> In the few cases where there were nontrivial changes,
> they looked fine, though it was tedious to extract the diffs.

Ok I've committed this patch too now.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]