Re: [libvirt] [PATCH] check for XHTML1 DTDs availability

[Chris Lalancette <clalance redhat com>]

Daniel Veillard wrote:
> On Wed, Aug 13, 2008 at 08:10:36AM -0400, Daniel Veillard wrote:
>>   Well apparently the XSL output is post-processed by xmlling --valid --format
>> which then introduce a dependancy on the XHTML1 DTDs . If you don't have them
>> installed locally you will get validation error messages when building
>> in docs and the output will diverge.
>>
>>   The simplest solution for you is probably to make sure you have XHTML1
>> DTDs installed in your local XML catalog, which on RHEL/Fedora is as simple
>> as having the package xhtml1-dtds installed on your machine(s).
> 
>   The patch enclosed adds detection for the XHTML1 dtds at runtime on the 
> build machine, and should solve the problem of diverging docs, replace the
> XML validity warnings by a more general message and add the requirement
> when building the RPM. I guess this should solve the issue

Yes, that did it for me.  I like the warning message too; at least that gives
someone a fighting chance of figuring out what to install if they do want to
generate the docs for some reason.

+1

Chris Lalancette