Re: [libvirt] [PATCH] "static" ip address

[Daniel Veillard <veillard redhat com>]

On Fri, Aug 15, 2008 at 10:43:15AM +0100, Daniel P. Berrange wrote:
> On Tue, Aug 12, 2008 at 05:24:01PM -0400, Daniel Veillard wrote:
> >   New patch with just a pair of minor fixes which seems to work just fine for
> > me. The syntax is nearly the old one, just use host instead of statichost:
> > 
> >   <ip address="192.168.122.1" netmask="255.255.255.0">
> >     <dhcp>
> >       <range start="192.168.122.4" end="192.168.122.254" />
> >       <host mac="00:16:3E:XX:XX:XX" host="XXX"
> 
> Seems a little odd to have 'host' as the element name and attribute
> name at once. Perhaps the atribute should just be name='XXXX' ?

  Okidoc, so I commited the patch but changed the attribute to name
instead of host, nicer and makes more sense,

  thanks,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/