Re: [libvirt] [PATCH] Fix disk device ordering

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Aug 21, 2008 at 11:21:15PM -0400, Cole Robinson wrote:
> When parsing the domain xml, disks are supposed to be
> rearranged in an alphabetic order based on bus type
> and target. The reordering code had a flaw though, in
> that it would always put the first disk it encountered
> at the head of the list, and had no way of putting
> new entries in front of it.

Hmm, yes good catch.

> 
> The attached patch reworks the code to compare the new
> disk against the current disk entry (rather than the
> next entry like the existing code). Seems to pass all
> my tests.

If the test suite passes that's good enough for me - we have a
test case which explicitly does lots of disks with different
buses & names for this.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|