Re: [libvirt] [PATCH] storage pool discovery

[Jim Meyering <jim meyering net>]

David Lively <dlively virtualiron com> wrote:
...
>> >  AM_CONDITIONAL([WITH_STORAGE_FS], [test "$with_storage_fs" = "yes"])
>> > +if test "$with_storage_fs" = "yes"; then
>> > +  AC_PATH_PROG([SHOWMOUNT], [showmount], [], [$PATH:/sbin:/usr/sbin])
>> > +  AC_DEFINE_UNQUOTED([SHOWMOUNT], ["$SHOWMOUNT"],
>> > +    [Location or name of the showmount program])
>> > +fi
>>
>> Do we want to require the "showmount" package via the spec file?
>
> I was a little worried about this too.  It's probably better to handle
> this more like "iscsiadmin"/--with-storage-iscsi: defaults to enabling
> iscsi backend if and only if iscsiadmin is present.  Fails with
> --with-storage-iscsi=yes explicitly specified and iscsiadmin not found.

Adding "Requires: showmount" and BuildRequires lines to
libvirt.spec.in would be similar to the approach of requiring
the iscsi-initiator-utils package (which contains iscsiadm):

    $ grep isc *.spec.in
    Requires: iscsi-initiator-utils
    BuildRequires: iscsi-initiator-utils