Re: [libvirt] [PATCH] virsh dump should not be live

[John Levon <levon movementarian org>]

On Thu, Aug 28, 2008 at 03:17:06PM +0100, Daniel P. Berrange wrote:

> On Thu, Aug 28, 2008 at 03:12:06PM +0100, John Levon wrote:
> > 
> > Live dumps are much less likely to produce usable cores. They also
> > trigger a Xen bug that crashes xend.
> 
> Better still, we should make use of the '@flags: extra flags, currently unused'
> parameter to virDomainDumpCore() to allow requesting of live vs offline
> dumps, since both have valid use cases.

Well that would be nice, I agree, but I'm fixing a bug here not adding
features. I really don't have time to go off and implement extra stuff
right now.

regards
john