Re: [libvirt] PATCH: 10/28: Thread safety for LXC driver

[Daniel Veillard <veillard redhat com>]

On Sun, Nov 30, 2008 at 11:50:30PM +0000, Daniel P. Berrange wrote:
> This patch makes the LXC driver thread safe following the same pattern
> as the Test/QEMU drivers

  okay that starts to look familiar,

>  cleanup:
>      virDomainDefFree(def);
> +    if (vm)
> +        virDomainObjUnlock(vm);

  Maybe it's just simpler to make virDomainObjUnlock accept and ignore
NULL rather than doing that check in all driver functions.

  Okay, I didn't spot anything, +1

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/