Re: [libvirt] [PATCH] rpcgen fixes

[John Levon <john levon sun com>]

On Wed, Dec 17, 2008 at 02:24:29PM +0100, Jim Meyering wrote:

> This sounds like an argument for not putting derived sources
> in CVS, since derived-for-one-system (linux/gnu) doesn't
> work for e.g., Solaris.

If you're OK with requiring rpcgen, that's most likely fine by me
(though you'd want to tighten up that glibc rpcgen check!)


> > +	rpcgen -h -o rp.h-t @top_srcdir@/qemud/remote_protocol.x
> > +	rpcgen -c -o rp.c-t @top_srcdir@/qemud/remote_protocol.x
> 
> Use $(srcdir), in place of @top_srcdir@/qemud (and others below).
> The latter @var@ syntax is old, if not deprecated,

Coo, been a while - will do.

> > +	perl -w @top_srcdir@/qemud/rpcgen_fix.pl rp.h-t \
> > +	    >@top_srcdir@/qemud/remote_protocol.h
> 
> Please don't redirect directly to something used as a build source.
> Instead, redirect to a temporary file, and rename that into place
> upon successful completion.  That makes it less likely you'll ever
> end up with corrupted sources.

Sorry I'm missing why this helps any?

regards
john