[Libvir] don't use virBufferAdd with string literals
Richard W.M. Jones
rjones at redhat.com
Tue Feb 5 10:33:17 UTC 2008
Jim Meyering wrote:
> I noticed a little glitch here:
>
> src/xml.c: virBufferAdd(buf, "(usbdevice tablet)", 13);
> src/xml.c: virBufferAdd(buf, "(usbdevice tablet)", 18);
Ouch, that's a "how did that ever work".
I see from that patch that you know about passing -1 as the length, in
which case virBufferAdd will use strlen. Of course that's a redundant
run-time strlen, as opposed to a compile-time sizeof.
+1 to the patch.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080205/72ebdbab/attachment-0001.bin>
More information about the libvir-list
mailing list