[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] don't use virBufferAdd with string literals
- From: Jim Meyering <jim meyering net>
- To: "Richard W.M. Jones" <rjones redhat com>
- Cc: Libvirt <libvir-list redhat com>
- Subject: Re: [Libvir] don't use virBufferAdd with string literals
- Date: Tue, 05 Feb 2008 15:23:02 +0100
"Richard W.M. Jones" <rjones redhat com> wrote:
> Jim Meyering wrote:
>> I noticed a little glitch here:
>>
>> src/xml.c: virBufferAdd(buf, "(usbdevice tablet)", 13);
>> src/xml.c: virBufferAdd(buf, "(usbdevice tablet)", 18);
>
> Ouch, that's a "how did that ever work".
>
> I see from that patch that you know about passing -1 as the length, in
> which case virBufferAdd will use strlen. Of course that's a redundant
> run-time strlen, as opposed to a compile-time sizeof.
>
> +1 to the patch.
Thanks for the review.
I've committed it.
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]