Re: [Libvir] [PATCH] change a Disk/Nic of inactive domain

[Daniel Veillard <veillard redhat com>]

On Tue, Feb 05, 2008 at 04:00:14PM -0800, Ryan Scott wrote:
> 
> Resurrecting a two-week old thread...
> 
> Was a version of this patch ever committed?  I don't see it, but I may 
> have missed it.
> 
> I used an earlier version of the patch to fix a problem we've noticed, 
> but I would like to see the final version of the patch.

  Well Apparently Rich didn't commit his version. So I applied the
patch made the two changes he suggested, a bit of reformating,

 this should now be in CVS,

  thanks everybody !

Daniel

> S.Sakamoto wrote:
> >>>>These struct definitions *intentionally* private.
> >>>Oops, I did not notice it...
> >>>
> >>>I revised a patch not to access the struct data directly.
> >>In principle this patch looks good.  If no one else objects, I'll commit 
> >>this, with a few of my own fixes (below).
> >>
> >>Rich.
> >>
> >>+        (obj->stringval) && !strcmp((char*)obj->stringval, "hvm"))
> >>
> >>I'm going to use STREQ macro here instead of !strcmp.
> >>
> >>+    if (ctxt)
> >>+        xmlXPathFreeContext(ctxt);
> >>
> >>There are a few potential double-frees on the cleanup path.  Need to set 
> >>ctxt back to NULL after freeing it.
> >>
> >Thank you for improving my patch!
> >Because it looks like that no one else objects, please commit this.
> >
> >Thanks,
> >Shigeki Sakamoto.
> >
> >--
> >Libvir-list mailing list
> >Libvir-list redhat com
> >https://www.redhat.com/mailman/listinfo/libvir-list
> 
> --
> Libvir-list mailing list
> Libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/