[Libvir] python/libvir.c returning wrong value on error?

Cole Robinson crobinso at redhat.com
Wed Feb 6 20:18:13 UTC 2008


Hi all,

Looking at python/libvir.c, all the custom functions return VIR_PY_NONE
on error. This unfortunately doesn't map well to some of the
generated python bindings which expect an error val of -1. So if these
commands fail, no exception will be thrown at the python level.
(Ex. virDomainGetAutostart, virDomainGetVcpus and their python equiv.)

I'm wondering where the fix should be: in python/libvir.c, changing
these error return values, or in the generator somewhere?

Thanks,
Cole




More information about the libvir-list mailing list