Re: [Libvir] [patch 1/3] Move static function prototype from header

[Daniel Veillard <veillard redhat com>]

On Wed, Feb 06, 2008 at 11:07:53PM +0000, Mark McLoughlin wrote:
> Fixes:
> 
>   xm_internal.h:64: error: 'xenXMDomainAttachDevice' declared 'static' but never defined
>   xm_internal.h:65: error: 'xenXMDomainDetachDevice' declared 'static' but never defined
> 
> Signed-off-by: Mark McLoughlin <markmc redhat com>
> 
> Index: libvirt/src/xm_internal.c
> ===================================================================
> --- libvirt.orig/src/xm_internal.c
> +++ libvirt/src/xm_internal.c
> @@ -77,6 +77,8 @@ static int xenXMAttachDisk(virDomainPtr 
>                              xmlNodePtr node, xenXMConfCachePtr entry);
>  static int xenXMAttachInterface(virDomainPtr domain, xmlXPathContextPtr ctxt, int hvm,
>                                  xmlNodePtr node, xenXMConfCachePtr entry);
> +static int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml);
> +static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
>  
>  #define XM_REFRESH_INTERVAL 10
>  
> Index: libvirt/src/xm_internal.h
> ===================================================================
> --- libvirt.orig/src/xm_internal.h
> +++ libvirt/src/xm_internal.h
> @@ -61,9 +61,6 @@ int xenXMDomainUndefine(virDomainPtr dom
>  virConfPtr xenXMParseXMLToConfig(virConnectPtr conn, const char *xml);
>  char *xenXMDomainFormatXML(virConnectPtr conn, virConfPtr conf);
>  
> -static int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml);
> -static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml);
> -
>  #ifdef __cplusplus
>  }
>  #endif

  Yup noticed the warning on Tuesday, thanks for chasing it, +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/