[Libvir] [patch 3/3] Do not inline xstrtol functions

Mark McLoughlin markmc at redhat.com
Thu Feb 7 10:10:34 UTC 2008


On Thu, 2008-02-07 at 05:02 -0500, Daniel Veillard wrote:
> On Wed, Feb 06, 2008 at 11:07:55PM +0000, Mark McLoughlin wrote:

> > Alternative is to not build with -Winline.
> 
>   That sounds a weak way to try to avoid a problem, we should
> not rely on just compiler options to get the code to compile and link.
> 
>   My preference would be to use the patch to make them real internal
> APIs without exporting all the functions, I think only xstrtol_i is
> used by external programs (virsh and qemud), and maybe we can add only
> that one to the list of exported symbols.

	Yeah, good point. Like this?

Cheers,
Mark.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-do-not-inline-string-funcs.patch
Type: text/x-patch
Size: 14068 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080207/e06ef72d/attachment-0001.bin>


More information about the libvir-list mailing list