Re: [Libvir] [PATCH] Avoid link errors with "configure --disable-shared".

[Jim Meyering <jim meyering net>]

"Daniel P. Berrange" <berrange redhat com> wrote:

> On Wed, Feb 27, 2008 at 04:52:21PM +0100, Jim Meyering wrote:
>> I got link errors when building with --disable-shared, and finally
>> fixed it.  Here's most of the solution.  The patch after this one
>> adjusts the gcov (test-coverage)-related things so that works with
>> the new setup, too.
>> diff --git a/src/libvirt_sym.version b/src/libvirt_sym.version
>> index 38b631e..581f380 100644
>> --- a/src/libvirt_sym.version
>> +++ b/src/libvirt_sym.version
>> @@ -32,6 +32,7 @@
>>  	virDomainLookupByName;
>>  	virDomainLookupByUUID;
>>  	virDomainLookupByUUIDString;
>> +	virDomainParseXMLDesc;
>
> This is not part of the public API.

Good catch.
I needed that with an earlier incarnation of this work,
but no longer.

>> @@ -184,6 +185,8 @@
>>          __virBufferVSprintf;
>>          __virBufferAdd;
>>          __virBufferAddChar;
>> +        __virErrorMsg;
>> +        __virRaiseError;
>
> What uses these two symbols ? AFAIK they shoudl only ever be
> called by internal drivers and not exported

Same here.

With those adjustments, the only changes to libvirt_sym.version
are to remove some SPACE-before-TAB.