Re: [Libvir] [patch 5/9] Include the iptables command and chain name in the saved rules file

["Daniel P. Berrange" <berrange redhat com>]

On Fri, Jan 04, 2008 at 03:57:30PM +0000, Mark McLoughlin wrote:
> lokkit --custom-rules expects the passed file to include the
> iptables command and chain name (e.g. "--inset INPUT") rather
> than just the rest of the arguments.
> 
> Add both of those to what will be saved to the rules file
> and simplify the resulting code by splitting out a
> argvToString() helper function.
> 
> The one complication is that when we're removing a rule
> we need to make sure we don't search for it using
> "--delete" rather than "--insert". For that reason,
> only change the argument to "--delete" once we've
> constructed the string we use to search through the
> existing rules.

ACK.


Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|