[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] [PATCH] Clean up global name space in examples and tests.
- From: "Daniel P. Berrange" <berrange redhat com>
- To: "Richard W.M. Jones" <rjones redhat com>
- Cc: Libvirt <libvir-list redhat com>
- Subject: Re: [Libvir] [PATCH] Clean up global name space in examples and tests.
- Date: Mon, 14 Jan 2008 13:53:46 +0000
On Mon, Jan 14, 2008 at 12:33:05PM +0000, Richard W.M. Jones wrote:
> Jim Meyering wrote:
> >These don't really matter, other than to remove false-positives
> >if/when we ever automate checks for unnecessarily-global symbols.
> >
> > Clean up global name space in examples and tests.
> > * docs/examples/suspend.c: Declare global "conn" to be static.
> > * tests/qemuxml2argvtest.c: Declare global "driver" to be static.
> > * tests/qemuxml2xmltest.c: Likewise.
>
> +1.
ACK
Dan
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]