Re: [Libvir] PATCH: Fix block device numbers for virDomainBlockStats

[Daniel Veillard <veillard redhat com>]

On Sun, Jan 27, 2008 at 08:32:10PM +0000, Daniel P. Berrange wrote:
> As mentioned in this thread:
> 
> http://www.redhat.com/archives/libvir-list/2008-January/msg00475.html
> 
> The code for calculating block devices numbers has a number of flaws.
> This patch fixes the flaws and adds a comprehensive test program to
> validate it. The test program also validates invalid cases.
> 
> NB, this code is actually now more perfect than Xen, since Xen doesn't
> handle SCSI disks > sdp, even though you can go all the way to sdhv.

  Change sounds a good idea, I assume Jim's review is sufficient
to get it though, so +1 on principle,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/