Re: [libvirt] RFC: virt-console

[John Levon <levon movementarian org>]

On Tue, Jul 01, 2008 at 11:56:25AM -0400, Daniel Veillard wrote:

> On Tue, Jul 01, 2008 at 04:21:38PM +0100, John Levon wrote:
> > 
> > See implementation here:
> > 
> > http://cr.opensolaris.org/~johnlev/virt-console/
> > 
> > (inside libvirt.hg/patches/libvirt/virt-console)
> 
>   Hum :-)
> 
> ++ * Daniel Berrange <berrange redhat com>
> ++ *
> ++ * Copyright 2008 Sun Microsystems, Inc.  All rights reserved.

What?

> > This splits virsh console into a separate binary to allow it to be
> > setuid-root on Solaris (where we check permissions then drop privilege).
> > It also fixes a number of RFEs
> > 
> > This is against 0.4.0, so it's not ready for merging yet (I hope to get
> > it forward ported at some point).
> 
>   I may be mistaken but this seems to basically be limited to console 
> for domains running on the local machine, and hum, I doubt it's really
> a good approach.

This is an incremental improvement over what exists in the current code
(and indeed, is a partially a response to code review comments from
Dan). It's not reasonable to expect me to go off and implement
something else altogether (a remote console server).

regards
john