[libvirt] [PATCH] virsh edit command

[John Levon]

On Tue, Jul 29, 2008 at 05:00:27PM +0100, Richard W.M. Jones wrote:

> > Isn't the *right* solution to this problem to finally add property
> > set/get interface for the things people actually want to modify, like
> > boot flags?
> 
> Do you mean things like the current 'virsh attach-device' / 'virsh
> detach-device' interface?

I hope not... that's just as bad as editing the domain XML.

> I'm responding here to a need that sysadmins feel they have -- to edit
> the configuration file (even if it's XML).  Witness an endless series
> of questions on this subject on the #virt channel yesterday.

Right. But to my mind you're fixing the symptom not the problem. *Why*
do they need to edit the XML? I ask this of everybody who complains at
me about having to edit XML: 99% of the time it's wanting to change boot
flags, but it's also stuff like turning off ACPI, setting on_crash, etc.

Editing XML is absolutely not user friendly, and adding 'edit' just
papers over the real problems IMHO.

regards
john