Re: [libvirt] [PATCH] lxc: new tty for container

[Daniel Veillard <veillard redhat com>]

On Fri, Jun 06, 2008 at 10:29:04AM +0100, Daniel P. Berrange wrote:
> On Thu, Jun 05, 2008 at 11:59:34PM -0700, Dave Leskovec wrote:
> > The lxc driver xml parser treats the console element as input when it should be
> > output only.  This obviously causes problems when anything other than /dev/ptmx
> > is specified or when a container is shutdown and then restarted without
> > redefining it (so that the console field is reset).  This patch treats the
> > console element as output only and always creates a new device when starting a
> > container.  Also fixed up a string overflow when storing the device name.
> 
> Yes, this is good. When using PTY's this is definitely output-only. No one
> should be using the ancient manually allocated pre-Unix98 TTYs. I'd not come
> across posix_openpt() before though - I'm used to openpty(). Since this is
> a Linux specific driver though, there's no portability issues to worry about
> so I'm happy with either.

  Fine by me too, +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/