Re: [libvirt] [PATCH 4 of 4] [LXC] Add setup/cleanup of container network interfaces

[Daniel Veillard <veillard redhat com>]

On Tue, Jun 24, 2008 at 08:51:36AM -0700, Dan Smith wrote:
> Changes:
>  - Remove extraneous "i" variables from various functions
>  - Only bring up lo if we have other interfaces (and thus NETNS)
>  - Fail setup of interfaces if NETNS support is not present
>  - Only add CLONE_NEWNET to start flags if domain has interfaces defined
>  - Make lxc_vm_t parameters const in helper functions (where appropriate)
>  - Cleanup DomainStart procedure to bail on start/move/continue errors

  Looks fine to me, +1

   thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/