Re: [libvirt] PATCH: 1/2: port Test driver to network APIs

[Daniel Veillard <veillard redhat com>]

On Tue, Jun 24, 2008 at 04:59:18PM +0100, Daniel P. Berrange wrote:
> This patch ports the Test driver to use the network XML apis.
> 
> Basically the 'struct _testNet' is removed, and replaced by usage of the
> generic virNetworkObjPtr and virNetworkDefPtr objects. The XML parser
> and formatters are ripped out and replaced by calls to the generic APIs
> in network_conf.h. Finally there is just alot of cleanup of all the 
> individual network driver implementations to adjust to the style of the
> new APIs used.

  Specific code shrinking, good :-)

Looks fine to me, having the default network configuration isolated
as an XML made it clearer to me, even better,

 +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/