Re: [Libvir] many more translatable strings need to be marked

["Daniel P. Berrange" <berrange redhat com>]

On Fri, Feb 29, 2008 at 10:02:35AM -0500, Daniel Veillard wrote:
> On Fri, Feb 29, 2008 at 03:48:18PM +0100, Jim Meyering wrote:
> > I've found many more strings that should be marked for translation.
> > The first part of this change is to add to the list of
> > diagnostic-printing function names in Makefile.maint and to
> > make that list more readable.
> > 
> > I marked some strings, but am leaving the rest, for now.  Running "make
> > sc_unmarked_diagnostics" shows over 300 strings remaining to be marked
> > with _(...).  However, while marking them is a big step, it's not all.
> > Once they're all marked, then we'll have to go back and with the help
> > of the right build options (--disable-nls and -Wformat -Wformat-security),
> > or just some judicious grepping through your patch,
> > add "%s" before each _("...") string that contains no "%" directive.
> 
>   While I undertand the point maybe it's pushed a bit too much, or not enough
> 
> >      if (args->maxnames > REMOTE_DOMAIN_NAME_LIST_MAX) {
> >          remoteDispatchError (client, req,
> > -                             "maxnames > REMOTE_DOMAIN_NAME_LIST_MAX");
> > +                             "%s", _("maxnames > REMOTE_DOMAIN_NAME_LIST_MAX"));
> 
>    The net effect of soem of those is that strings which are basically
> untranslatable will be pushed to the small army of benevolent translators
> worldwide, and I'm afraid they are gonna be quite annoyed when facing such
> strings. 

This is an argument for fixing the error message to be something more useful.
eg, "Too many domain names received"

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|