Re: [libvirt] PATCH [2/2]: Deprecate conn, dom, net fields in struct _virError

[Jim Meyering <jim meyering net>]

"Richard W.M. Jones" <rjones redhat com> wrote:
> Index: include/libvirt/libvirt.h.in
> ===================================================================
> RCS file: /data/cvs/libvirt/include/libvirt/libvirt.h.in,v
> retrieving revision 1.48
> diff -u -r1.48 libvirt.h.in
> --- include/libvirt/libvirt.h.in	15 May 2008 06:12:32 -0000	1.48
> +++ include/libvirt/libvirt.h.in	22 May 2008 16:56:58 -0000
> @@ -21,6 +21,14 @@
>  extern "C" {
>  #endif
>
> +#ifndef VIR_DEPRECATED
> +#ifdef __GNUC__
> +#define VIR_DEPRECATED __attribute__((deprecated))
> +#else
> +#define VIR_DEPRECATED /* nothing */
> +#endif
> +#endif /* VIR_DEPRECATED */

This feature appears to have been introduced in gcc-3.1, so define
away for earlier versions.

Also, it's better for name-space cleanliness to use the __...__ form:

#ifndef VIR_DEPRECATED
  /* The feature is present in gcc-3.1 and newer.  */
# if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 1)
#  define VIR_DEPRECATED __attribute__((__deprecated__))
# else
#  define VIR_DEPRECATED /* nothing */
# endif
#endif /* VIR_DEPRECATED */